deploy and un deploy functionality#3073
Merged
msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom Aug 9, 2023
Merged
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
- Coverage 33.77% 32.71% -1.07%
==========================================
Files 73 74 +1
Lines 4755 4934 +179
Branches 907 940 +33
==========================================
+ Hits 1606 1614 +8
- Misses 3149 3320 +171
☔ View full report in Codecov by Sentry. |
Contributor
|
I tested deploying onto the sandbox cluster, since I couldn't figure out how to set up Knative serverless on Here are a few things I ran into:
|
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Collaborator
Author
@datho7561 addressed the feedback that you provided. Please have a look |
datho7561
approved these changes
Aug 9, 2023
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Looks good and works well for me! Thanks, Muthu!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3010