Skip to content

config functionality added#3117

Merged
datho7561 merged 2 commits intoredhat-developer:mainfrom
msivasubramaniaan:3056-configure-a-env-variable-in-serverless-webview
Aug 23, 2023
Merged

config functionality added#3117
datho7561 merged 2 commits intoredhat-developer:mainfrom
msivasubramaniaan:3056-configure-a-env-variable-in-serverless-webview

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

@msivasubramaniaan msivasubramaniaan commented Aug 23, 2023

Fixes: #3056

Added below functionalities on this PR

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage: 28.12% and project coverage change: -0.04% ⚠️

Comparison is base (baa17ad) 32.82% compared to head (442bee3) 32.78%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3117      +/-   ##
==========================================
- Coverage   32.82%   32.78%   -0.04%     
==========================================
  Files          74       74              
  Lines        4960     4987      +27     
  Branches      944      947       +3     
==========================================
+ Hits         1628     1635       +7     
- Misses       3332     3352      +20     
Files Changed Coverage Δ
src/cli.ts 77.50% <0.00%> (-1.99%) ⬇️
src/serverlessFunction/commands.ts 14.28% <0.00%> (-3.37%) ⬇️
src/serverlessFunction/build-run-deploy.ts 5.35% <33.33%> (+0.37%) ⬆️
src/serverlessFunction/view.ts 32.59% <50.00%> (+2.34%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Muthu!

@datho7561 datho7561 merged commit 05ca618 into redhat-developer:main Aug 23, 2023
@msivasubramaniaan msivasubramaniaan deleted the 3056-configure-a-env-variable-in-serverless-webview branch August 23, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure a function in serverless webview

2 participants