Background colour for "Create Function" wizard should respect theme.#3133
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Aug 29, 2023
Merged
Conversation
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3133 +/- ##
=======================================
Coverage 31.99% 31.99%
=======================================
Files 74 74
Lines 5122 5122
Branches 974 974
=======================================
Hits 1639 1639
Misses 3483 3483 ☔ View full report in Codecov by Sentry. |
datho7561
approved these changes
Aug 29, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Roland!
FYI, there's a method of handling light theme vs dark theme built-in to Material UI that we used for create component that I would like to use for all webviews in the future, but as a quick fix this works well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change on a light theme:
I'm actually not sure what
colordoes in this instance as I wasn't able to see it shown at all, but I've also changed that to what seems like a better value.