Skip to content

3128 create serverless function based on repository template#3240

Merged
msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan:3128-create-serverless-function-based-on-repository-template
Sep 8, 2023
Merged

3128 create serverless function based on repository template#3240
msivasubramaniaan merged 3 commits intoredhat-developer:mainfrom
msivasubramaniaan:3128-create-serverless-function-based-on-repository-template

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Fixes: #3128

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14% ⚠️

Comparison is base (fa9a012) 37.56% compared to head (9866c9b) 37.43%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3240      +/-   ##
==========================================
- Coverage   37.56%   37.43%   -0.14%     
==========================================
  Files          77       77              
  Lines        5271     5279       +8     
  Branches     1000     1003       +3     
==========================================
- Hits         1980     1976       -4     
- Misses       3291     3303      +12     
Files Changed Coverage Δ
src/serverlessFunction/commands.ts 7.05% <0.00%> (-0.35%) ⬇️
src/serverlessFunction/functions.ts 4.31% <0.00%> (-0.09%) ⬇️
...ew/serverless-function/serverlessFunctionLoader.ts 14.01% <0.00%> (-1.22%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works for me. Thanks, Muthu!

@datho7561
Copy link
Copy Markdown
Contributor

There are merge conflicts

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator Author

There are merge conflicts

I haven't seen any conflicts. May I know which file u meant?

@msivasubramaniaan msivasubramaniaan merged commit 16b560a into redhat-developer:main Sep 8, 2023
@msivasubramaniaan msivasubramaniaan deleted the 3128-create-serverless-function-based-on-repository-template branch September 8, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create serverless Function based on repository template

2 participants