Removed current namespace from serverless function tree view#3241
Merged
datho7561 merged 5 commits intoredhat-developer:mainfrom Sep 8, 2023
Conversation
Signed-off-by: msivasubramaniaan <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3241 +/- ##
==========================================
- Coverage 37.56% 37.29% -0.28%
==========================================
Files 77 77
Lines 5271 5248 -23
Branches 1000 993 -7
==========================================
- Hits 1980 1957 -23
Misses 3291 3291
☔ View full report in Codecov by Sentry. |
datho7561
requested changes
Sep 8, 2023
Signed-off-by: msivasubramaniaan <[email protected]>
Contributor
|
There is also this file watcher, which I think is only used to track the current namespace: https://github.com/redhat-developer/vscode-openshift-tools/pull/3241/files#diff-7b252f53014e39d3101cc51d5a916d9da0cddcc8467c63aa901db00a85ee2c61R68 |
Signed-off-by: msivasubramaniaan <[email protected]>
Signed-off-by: msivasubramaniaan <[email protected]>
Signed-off-by: msivasubramaniaan <[email protected]>
datho7561
approved these changes
Sep 8, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Muthu!
Contributor
|
(waiting for CI) |
msivasubramaniaan
deleted the
3145-tree-item-in-the-serverless-functions-view-keeps-name-of-the-latest-used-project
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3145