add port number support

[msivasubramaniaan]

Fixes: #2781

[codecov]

Codecov Report

Patch coverage: 18.75% and project coverage change: -0.89% ⚠️

Comparison is base (b1ef719) 37.14% compared to head (1e3b137) 36.25%.
Report is 1 commits behind head on main.

❗ Current head 1e3b137 differs from pull request most recent head a23c956. Consider uploading reports for the commit a23c956 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3292      +/-   ##
==========================================
- Coverage   37.14%   36.25%   -0.89%     
==========================================
  Files          77       77              
  Lines        5333     5359      +26     
  Branches     1024     1033       +9     
==========================================
- Hits         1981     1943      -38     
- Misses       3352     3416      +64     

Files Changed	Coverage Δ
src/odo/componentType.ts	62.50% <ø> (ø)
.../webview/create-component/createComponentLoader.ts	10.81% <0.00%> (-0.31%)	⬇️
src/webview/common-ext/createComponentHelpers.ts	14.45% <10.00%> (-0.41%)	⬇️
src/webview/devfile-registry/registryViewLoader.ts	25.86% <16.66%> (-1.17%)	⬇️
src/odo.ts	71.51% <20.00%> (-11.52%)	⬇️
src/openshift/nameValidator.ts	47.82% <50.00%> (ø)
src/odo/command.ts	64.80% <100.00%> (-3.50%)	⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[msivasubramaniaan]

@datho7561 Thanks for your review. I just addressed the review comments and pushed the code. Can you please have a look on the latest code?

[datho7561]

Looks good, and works well. Thanks, Muthu!

[datho7561]

It seems like there are linter errors

[msivasubramaniaan]

It seems like there are linter errors

Fixed lint errors

[mohitsuman]

@msivasubramaniaan can you please share the gif/video of how it behaves.

[datho7561]

Here's what it looks like:

[datho7561]

Here's a small bug I found:

• Create a component, then delete it's devfile and .odo so that it's not recognized as a component
• Right click on the folder, then select "create component from folder"
• Set the port to 9090, then click next
• The port gets changed to 3000. I guess it's being auto detected from the node project?
• Click "Create Component"
• I get the error message "portNumber.trim is not a function":

[datho7561]

The integration tests seem to be failing.

[msivasubramaniaan]

@mohitsuman Here is the demo gif:

[datho7561]

Currently, you can't set the port for components created from template or imported from git

It's actually only in the "from template" case. I think it's okay to not show the option there, since the port is also set in the sample code, so it's misleading to set the port in the devfile but provide the code with the old port.

[datho7561]

Looks good! Feel free to merge after rebasing

[msivasubramaniaan]

@datho7561 Thanks for your review.