Skip to content

Propagate errors from odo#330

Closed
jrichter1 wants to merge 1 commit intoredhat-developer:masterfrom
jrichter1:odo-errors
Closed

Propagate errors from odo#330
jrichter1 wants to merge 1 commit intoredhat-developer:masterfrom
jrichter1:odo-errors

Conversation

@jrichter1
Copy link
Copy Markdown
Member

attempt to fix #249. Not sure if it's the best solution, but I don't fancy changing all the code that uses odo.execute

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2018

Codecov Report

Merging #330 into master will increase coverage by 0.43%.
The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   35.55%   35.98%   +0.43%     
==========================================
  Files          19       19              
  Lines         827      831       +4     
  Branches      124      125       +1     
==========================================
+ Hits          294      299       +5     
+ Misses        533      532       -1
Impacted Files Coverage Δ
src/odo.ts 33.13% <47.36%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de7b11...d1a977c. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 using odo.execute rather than cli directly, doing the same here #333.
I don't want to change error handling now to avoid unexpected errors, knowing we don't have good unit tests coverage.

@jrichter1
Copy link
Copy Markdown
Member Author

closing as this was done in #406

@jrichter1 jrichter1 closed this Nov 28, 2018
@jrichter1 jrichter1 removed the review label Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

odo execution errors are passing through undetected

2 participants