Prevent crash when loading workspace with deleted folder#3358
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Sep 28, 2023
Merged
Conversation
Contributor
Author
|
@dgolovin if you have time, could you please check if this fixes your issue? |
datho7561
force-pushed
the
3356-failed-to-watch-directory
branch
from
1f3d1da to
d519b80
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3358 +/- ##
==========================================
+ Coverage 36.96% 37.01% +0.05%
==========================================
Files 77 77
Lines 5367 5373 +6
Branches 1034 1035 +1
==========================================
+ Hits 1984 1989 +5
- Misses 3383 3384 +1
☔ View full report in Codecov by Sentry. |
dgolovin
previously approved these changes
Sep 27, 2023
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
Works for me.
See my comment about empty catch bloc added (fixing is optional).
Fixes redhat-developer#3356 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
3356-failed-to-watch-directory
branch
from
d519b80 to
599352e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3356
Signed-off-by: David Thompson davthomp@redhat.com