Add "go back" possibility to cluster login quick picks #3357#3359
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Oct 2, 2023
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
=========================================
+ Coverage 0 36.02% +36.02%
=========================================
Files 0 77 +77
Lines 0 5549 +5549
Branches 0 1068 +1068
=========================================
+ Hits 0 1999 +1999
- Misses 0 3550 +3550
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
How
|
datho7561
previously approved these changes
Sep 29, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Seems to work well. Found some dead code
…er#3357 Fixes: redhat-developer#3357 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
force-pushed
the
fix-cluster-login-quick-pick-add-go-back-possibility
branch
from
2a566fc to
161a45f
Compare
datho7561
approved these changes
Oct 2, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Victor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3357