Terminal: keybinding and context menu for copy & select all#3360
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Sep 29, 2023
Merged
Terminal: keybinding and context menu for copy & select all#3360datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3360 +/- ##
==========================================
+ Coverage 36.96% 36.97% +0.01%
==========================================
Files 77 77
Lines 5367 5384 +17
Branches 1034 1034
==========================================
+ Hits 1984 1991 +7
- Misses 3383 3393 +10 ☔ View full report in Codecov by Sentry. |
vrubezhny
previously approved these changes
Sep 29, 2023
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me,
Please see the comment inline
Adds the following keybindings to the OpenShift terminal: - `Ctrl+Shift+C`: copy selection - `Ctrl+Shift+A`: select all text Hide the existing broken context menu (provided by VS Code) and replace it with one with "Select All" and "Copy" items that actually work. This context menu imitates the style of VS Code's context menu. Closes redhat-developer#3353, closes redhat-developer#3137 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
3353-fix-terminal-copy
branch
from
20023c9 to
5f9f265
Compare
vrubezhny
approved these changes
Sep 29, 2023
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Look good and perfectly works!
Thanks!
Contributor
Author
|
Yay! Thanks for the review, Victor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following keybindings to the OpenShift terminal:
Ctrl+Shift+C: copy selectionCtrl+Shift+A: select all textHide the existing broken context menu (provided by VS Code) and replace it with one with "Select All" and "Copy" items that actually work. This context menu imitates the style of VS Code's context menu.
Closes #3353, closes #3137
Signed-off-by: David Thompson davthomp@redhat.com