If a command is rerun after exiting, close the old tab#3370
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Sep 29, 2023
Merged
If a command is rerun after exiting, close the old tab#3370datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
When you start a new command in the terminal, check if there is a tab open where that command was run and has exited. If there is, close that tab before opening an new tab to run the rerun of the command. Not quite the same as recycling the tab, but it has a much simpler implementation. Closes redhat-developer#3138 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
3138-reap-instead-of-recycle
branch
from
b28ef38 to
c3eb3a5
Compare
vrubezhny
approved these changes
Sep 29, 2023
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you start a new command in the terminal, check if there is a tab open where that command was run and has exited. If there is, close that tab before opening an new tab to run the rerun of the command. Not quite the same as recycling the tab, but it has a much simpler implementation.
Closes #3138
Signed-off-by: David Thompson davthomp@redhat.com