added percentage of completion on progress bar#3371
Merged
msivasubramaniaan merged 4 commits intoredhat-developer:mainfrom Sep 29, 2023
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3371 +/- ##
==========================================
- Coverage 37.03% 37.02% -0.02%
==========================================
Files 77 77
Lines 5373 5378 +5
Branches 1035 1033 -2
==========================================
+ Hits 1990 1991 +1
- Misses 3383 3387 +4
☔ View full report in Codecov by Sentry. |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
requested changes
Sep 28, 2023
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
previously approved these changes
Sep 29, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Works great as it currently is, but I think there is a small visual improvement you can make. Feel free to merge after making the change.
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
msivasubramaniaan
deleted the
3040-display-progress-information-during-import-git-clone-process
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3040
Post Fix:
