Skip to content

Context menu item to clear terminal#3378

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:3135-clear-terminal
Sep 29, 2023
Merged

Context menu item to clear terminal#3378
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:3135-clear-terminal

Conversation

@datho7561
Copy link
Copy Markdown
Contributor

Closes #3135

Signed-off-by: David Thompson davthomp@redhat.com

Closes redhat-developer#3135

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 requested a review from vrubezhny September 29, 2023 18:25
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (24e4830) 36.96% compared to head (02d6731) 36.93%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3378      +/-   ##
==========================================
- Coverage   36.96%   36.93%   -0.03%     
==========================================
  Files          77       77              
  Lines        5384     5388       +4     
  Branches     1034     1035       +1     
==========================================
  Hits         1990     1990              
- Misses       3394     3398       +4     
Files Coverage Δ
...rc/webview/openshift-terminal/openShiftTerminal.ts 10.47% <0.00%> (-0.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny
Copy link
Copy Markdown
Contributor

Perfectly works... It's just that the only one thing confuses me... See the different context menus we have (in Dark Theme):

context-menues

@datho7561
Copy link
Copy Markdown
Contributor Author

I have the "window.titleBarStyle": "custom" setting enabled. This setting makes all the context menus look like the one I added.

I think we might need to detect if this setting is enabled and switch between the two styles of context menu. The only issue is that I think the appearance varies between operating systems when "window.titleBarStyle": "custom" is disabled.

@vrubezhny
Copy link
Copy Markdown
Contributor

Yes, I had "window.titleBarStyle" === "native"... With "custom" all the other menus are looking "dark" exactly as the one from the OS Terminal.

I don't know, but probably it's better if all the application menus look the same way - color scheme/fonts/etc.

Copy link
Copy Markdown
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The context menu coloring issue - a color scheme on OS Terminal context menu looks different compared to other app context menus when Dark Theme and "window.titleBarStyle" === "native" preference are set - is not related to the Clear OS Terminal context menu action itself. We should probably open a different issue for this or leave as is.

@datho7561 datho7561 merged commit 27e73fe into redhat-developer:main Sep 29, 2023
@datho7561 datho7561 deleted the 3135-clear-terminal branch September 29, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button to clear contents of terminal in OpenShift Terminal view

2 participants