Add support to binary file for component creation#347
Merged
dgolovin merged 6 commits intoredhat-developer:masterfrom Nov 30, 2018
Merged
Add support to binary file for component creation#347dgolovin merged 6 commits intoredhat-developer:masterfrom
dgolovin merged 6 commits intoredhat-developer:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
+ Coverage 61.31% 61.83% +0.52%
==========================================
Files 20 20
Lines 853 870 +17
Branches 134 140 +6
==========================================
+ Hits 523 538 +15
- Misses 330 332 +2
Continue to review full report at Codecov.
|
Contributor
Author
|
testPR |
dgolovin
requested changes
Nov 17, 2018
Collaborator
dgolovin
left a comment
dgolovin
left a comment
There was a problem hiding this comment.
Tests should be fixed first.
Contributor
Author
|
testPR |
1 similar comment
Contributor
Author
|
testPR |
Contributor
Author
|
@dgolovin Please review. |
dgolovin
approved these changes
Nov 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #223