Add "OK" and "Cancel" buttons to cluster login quick picks input fields#3475
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Oct 25, 2023
Conversation
328466f to
0a88a2b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3475 +/- ##
==========================================
- Coverage 35.68% 35.43% -0.25%
==========================================
Files 79 79
Lines 5571 5613 +42
Branches 1096 1116 +20
==========================================
+ Hits 1988 1989 +1
- Misses 3583 3624 +41
☔ View full report in Codecov by Sentry. |
Contributor
|
If I try to add a new user, it errors and I get "Excpected a string but got an undefined" |
ea9a850 to
a8d6262
Compare
a8d6262 to
a0d55f4
Compare
Contributor
Author
|
No need to use keyboard if you already have your credentials saved: Screencast.from.2023-10-25.18-30-22.webmYou can go back from any step of login workflow: Screencast.from.2023-10-25.19-28-49.webm |
Contributor
Author
@datho7561 Fixed this as well as few other issues I found (returning back from login method selection) |
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
a0d55f4 to
fdd915b
Compare
datho7561
approved these changes
Oct 25, 2023
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Seems to be working well. Thank you, Victor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a possibility to finish or cancel an entering value operation (like, for new cluster URL, new username, password, token inputs) with pressing an
EnterorCancelclickable buttons: