Skip to content

Creating project into sandbox has user limitation #3336#3519

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-disable-switch-project-for-sandbox-cluster
Nov 3, 2023
Merged

Creating project into sandbox has user limitation #3336#3519
datho7561 merged 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-disable-switch-project-for-sandbox-cluster

Conversation

@vrubezhny
Copy link
Copy Markdown
Contributor

Fixes: #3336

Fixes: redhat-developer#3336

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e3538e1) 34.44% compared to head (ce5703b) 34.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3519      +/-   ##
==========================================
+ Coverage   34.44%   34.48%   +0.03%     
==========================================
  Files          81       81              
  Lines        5777     5785       +8     
  Branches     1156     1157       +1     
==========================================
+ Hits         1990     1995       +5     
- Misses       3787     3790       +3     
Files Coverage Δ
src/oc/ocWrapper.ts 71.05% <83.33%> (+0.68%) ⬆️
src/explorer.ts 30.17% <0.00%> (-0.53%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny
Copy link
Copy Markdown
Contributor Author

Now cluster is acquired if it's allowed to create a namespace/project on it and, if not, no New Project action:

Screenshot from 2023-11-03 17-55-02

... nor Change Active Project action is shown:

Screenshot from 2023-11-03 17-55-25

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Victor!

@datho7561 datho7561 merged commit 3d65214 into redhat-developer:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating project into sandbox has user limitation

2 participants