Add, delete and update support on helm repo#3617
Merged
msivasubramaniaan merged 5 commits intoredhat-developer:mainfrom Nov 26, 2023
Merged
Add, delete and update support on helm repo#3617msivasubramaniaan merged 5 commits intoredhat-developer:mainfrom
msivasubramaniaan merged 5 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
==========================================
- Coverage 34.22% 33.41% -0.82%
==========================================
Files 82 84 +2
Lines 5858 6096 +238
Branches 1171 1239 +68
==========================================
+ Hits 2005 2037 +32
- Misses 3853 4059 +206 ☔ View full report in Codecov by Sentry. |
datho7561
requested changes
Nov 23, 2023
Contributor
datho7561
left a comment
There was a problem hiding this comment.
A few things I noticed:
- Please add integration tests for the helm commands that you're running
- It would be nice if the list of charts in the chart view updated when you add/remove a repo, similar to what we do for Devfile registries
- IMO it's confusing having the list of repos in the tree view and the webview. I think it would be better if we only showed them in the webview, since from the webview you can add, edit and delete repositories, but from the tree view you can't do these things. As an alternative, maybe we can provide add, rename, and delete context menu options and just use quickpicks to set the information, similar to what we did for the devfile registry tree view.
Other things I noticed:
- I ran into this bug, which makes working with helm repos really annoying, I think we should address it in a separate issue though: #3622
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Collaborator
Author
|
@datho7561 The integration test I'll create the separate PR and fixed all other mentioned points. Please have a look |
datho7561
approved these changes
Nov 24, 2023
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Looks good, and seems to be working reliably. Thanks, Muthu!
Contributor
|
Looks like there are merge conflicts |
1 similar comment
Contributor
|
Looks like there are merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3609