Skip to content

Error popups on trying to delete a project on sandbox due to user lim…#3654

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-explorer-check-if-project-can-be-deleted
Nov 30, 2023
Merged

Error popups on trying to delete a project on sandbox due to user lim…#3654
datho7561 merged 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-explorer-check-if-project-can-be-deleted

Conversation

@vrubezhny
Copy link
Copy Markdown
Contributor

…itation #3643

Fixes: #3643

@vrubezhny vrubezhny requested a review from datho7561 November 29, 2023 20:57
@vrubezhny vrubezhny force-pushed the fix-explorer-check-if-project-can-be-deleted branch from 4aeb6e2 to 18b4adb Compare November 29, 2023 22:13
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (b859e8d) 33.31% compared to head (18b4adb) 33.24%.

Files Patch % Lines
src/oc/ocWrapper.ts 0.00% 9 Missing ⚠️
src/explorer.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3654      +/-   ##
==========================================
- Coverage   33.31%   33.24%   -0.08%     
==========================================
  Files          84       84              
  Lines        6114     6127      +13     
  Branches     1245     1248       +3     
==========================================
  Hits         2037     2037              
- Misses       4077     4090      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, Victor!

@datho7561 datho7561 merged commit 38bc97b into redhat-developer:main Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error popups on trying to delete a project on sandbox due to user limitation

2 participants