Skip to content

3701 update UX for helm view#3702

Merged
datho7561 merged 6 commits intoredhat-developer:mainfrom
msivasubramaniaan:3701-update-ux-for-helm-view
Dec 8, 2023
Merged

3701 update UX for helm view#3702
datho7561 merged 6 commits intoredhat-developer:mainfrom
msivasubramaniaan:3701-update-ux-for-helm-view

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Collaborator

Fixes: #3701

image

image

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ff12285) 33.24% compared to head (65ddee6) 33.23%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/webview/helm-chart/helmChartLoader.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3702      +/-   ##
==========================================
- Coverage   33.24%   33.23%   -0.02%     
==========================================
  Files          84       84              
  Lines        6127     6130       +3     
  Branches     1249     1252       +3     
==========================================
  Hits         2037     2037              
- Misses       4090     4093       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the tags sometimes overflow the detail page:

Screenshot from 2023-12-07 11-12-59

Comment thread src/webview/helm-chart/app/fromHelm.tsx Outdated
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan
Copy link
Copy Markdown
Collaborator Author

@datho7561 The mentioned UI issue was fixed.

image

@mohitsuman
Copy link
Copy Markdown
Contributor

@msivasubramaniaan Let's fix this wording here:

helperText = 'Only one versions available in this Chart';

Only one version is available for the Helm Chart

This is to fix the plural of version word.

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Copy link
Copy Markdown
Contributor

@mohitsuman mohitsuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@datho7561 datho7561 merged commit 953df42 into redhat-developer:main Dec 8, 2023
@msivasubramaniaan msivasubramaniaan deleted the 3701-update-ux-for-helm-view branch December 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update UX for Helm View

3 participants