Don't show "Open in Developer Console" on non-OpenShift clusters#3821
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Jan 18, 2024
Merged
Conversation
- Fix condition for when the context menu item is shown Fixes redhat-developer#3814 Signed-off-by: David Thompson <davthomp@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3821 +/- ##
=======================================
Coverage 32.41% 32.41%
=======================================
Files 85 85
Lines 6396 6396
Branches 1321 1321
=======================================
Hits 2073 2073
Misses 4323 4323 ☔ View full report in Codecov by Sentry. |
vrubezhny
approved these changes
Jan 18, 2024
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good and works like a charm! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3814
Signed-off-by: David Thompson davthomp@redhat.com