add terminal view context on serverless function session#3843
Merged
datho7561 merged 4 commits intoredhat-developer:mainfrom Jan 31, 2024
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3843 +/- ##
==========================================
- Coverage 33.12% 32.37% -0.75%
==========================================
Files 84 85 +1
Lines 6195 6505 +310
Branches 1270 1349 +79
==========================================
+ Hits 2052 2106 +54
- Misses 4143 4399 +256 ☔ View full report in Codecov by Sentry. |
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Collaborator
Author
|
Here is the demo for this PR: |
datho7561
requested changes
Jan 30, 2024
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
datho7561
approved these changes
Jan 31, 2024
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Muthu!
msivasubramaniaan
deleted the
3640-show-context-menu-to-open-in-terminal-for-the-function-created
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3640