Prompt the user to select a project#3847
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Jan 29, 2024
Merged
Conversation
Contributor
Author
|
Here is a demo of the workflow: create-or-select-project-prompt.mp4 |
vrubezhny
previously approved these changes
Jan 29, 2024
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
Contributor
Author
|
Checking the test failure before merging... |
Contributor
|
@datho7561 It only looks like the following test failure is related to the change: |
When trying to run "Start Dev", "Manually Start Dev", "Create" (to create resources from a YAML file), or "Delete" (to delete resources from a YAML file), if the current project doesn't exist, display a notification initicating that a project needs to be selected or created, with a button that opens the wizard to do this. Fixes redhat-developer#2581 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
dismissed stale reviews from msivasubramaniaan and vrubezhny
via
4df77b0
datho7561
force-pushed
the
2581-start-dev-requires-project
branch
from
c198d84 to
4df77b0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3847 +/- ##
==========================================
+ Coverage 32.47% 32.58% +0.11%
==========================================
Files 85 85
Lines 6418 6441 +23
Branches 1333 1337 +4
==========================================
+ Hits 2084 2099 +15
- Misses 4334 4342 +8 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I rewrote the test to reflect the new behaviour. Are you okay if I merge this @vrubezhny @msivasubramaniaan ? |
Contributor
|
@datho7561 +1 for merging the PR - All the tests successfully passed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run "Start Dev", "Manually Start Dev", "Create" (to create resources from a YAML file), or "Delete" (to delete resources from a YAML file), if the current project doesn't exist, display a notification initicating that a project needs to be selected or created, with a button that opens the wizard to do this.
Fixes #2581
Signed-off-by: David Thompson davthomp@redhat.com