Skip to content

Stop trying to connect to a cluster when it doesn't appear to be avai… #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datho7561 merged 1 commit into from
Jan 30, 2024
+10 −8
Merged

Stop trying to connect to a cluster when it doesn't appear to be avai… #3848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/openshift/cluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,10 +530,10 @@ export class Cluster extends OpenShiftItem {
);
if (promptResponse === startCrc){
await commands.executeCommand('openshift.explorer.addCluster', 'crc');
// no point in continuing with the wizard,
// it will take the cluster a few minutes to stabilize
return null;
}
// Anyway, no point in continuing with the wizard
return null;
} else if (Cluster.isSandboxCluster(clusterURL)) {
const devSandboxSignup = 'Sign up for OpenShift Dev Sandbox';
const promptResponse = await window.showWarningMessage(
Expand All @@ -543,15 +543,17 @@ export class Cluster extends OpenShiftItem {
);
if (promptResponse === devSandboxSignup){
await commands.executeCommand('openshift.explorer.addCluster', 'sandbox');
// no point in continuing with the wizard,
// the user needs to sign up for the service
return null;
}
} else {
void window.showWarningMessage(
'Unable to contact the cluster. Is it running and accessible?',
);
// Anyway, no point in continuing with the wizard
return null;
}

// Stop trying because the cluster doesn't appear to be available
void window.showWarningMessage(
'Unable to contact the cluster. Is it running and accessible?',
);
return null;
}
} while (!clusterIsUp);

Expand Down
⚡