Do not call getAllComponents() in activate#3880
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Feb 7, 2024
Merged
Do not call getAllComponents() in activate#3880datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3880 +/- ##
===========================================
+ Coverage 32.37% 45.40% +13.03%
===========================================
Files 85 85
Lines 6505 6488 -17
Branches 1349 1342 -7
===========================================
+ Hits 2106 2946 +840
+ Misses 4399 3542 -857 ☔ View full report in Codecov by Sentry. |
vrubezhny
requested changes
Feb 6, 2024
9ae98bd to
7b19597
Compare
Part of redhat-developer#3850 Signed-off-by: David Thompson <davthomp@redhat.com>
7b19597 to
09c4ab5
Compare
Contributor
Author
|
Good catch! I fixed this issue, and refactored the code related to collecting the list of Devfiles. |
Contributor
Author
|
Serverless function tests are failing for me. The root causes could be that something is preventing the refresh button from being pressed, or that VS Code reports it has run out of filesystem watchers during the tests. |
vrubezhny
approved these changes
Feb 7, 2024
Contributor
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me - Devfile Registry editing works fine and GH Actions tests are passed.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Part of #3850
Signed-off-by: David Thompson davthomp@redhat.com