Migrate Kubernetes extension commands #3990#4106
Migrate Kubernetes extension commands #3990#4106datho7561 merged 1 commit intoredhat-developer:mainfrom
Conversation
|
Loading Deployment/Pod YAMLs while the k8s extension isn't installed: Screencast.from.2024-05-08.02-43-03.webm |
c5f7caf to
771d39a
Compare
|
The 'release/yml' is to be updated as we don't need the |
771d39a to
778b138
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4106 +/- ##
===========================================
+ Coverage 32.37% 44.67% +12.29%
===========================================
Files 85 88 +3
Lines 6505 7074 +569
Branches 1349 1494 +145
===========================================
+ Hits 2106 3160 +1054
+ Misses 4399 3914 -485 ☔ View full report in Codecov by Sentry. |
a25ce9d to
3712338
Compare
@rgrunber Could you please review the change made to |
|
The change there looks fine. I think this could have been removed a while ago since it was already present in the package.json. Maybe we kept it because integration tests would fail if it was in the package.json, but that issue was resolved : #3091 . |
datho7561
left a comment
There was a problem hiding this comment.
Looks good and works well. See the comment about Helm support.
02c2fa2 to
ea361cf
Compare
|
Added Screencast.from.2024-05-08.20-52-08.webm |
8accdfa to
1b5767e
Compare
|
Doesn't seem to compile |
9dc57b8 to
097d1c6
Compare
|
Loading of Helm Chart Configuration document is added: Screencast.from.2024-05-09.15-23-09.webm |
7fbc8c5 to
d94bf49
Compare
|
@datho7561 Could you please take a look at the latest additions:
|
|
Double clicking on the Helm Release to load the information on it doesn't seem to work, I need to sue the context menu item instead. |
datho7561
left a comment
There was a problem hiding this comment.
Other than the comment about double-click opening not working for Helm installations (which I think is not a bit deal), this PR seems to be great! Let me know if you want to fix that before merging or merge as-is.
Forgot about this. I'll fix it. UPD: Now it should be fixed: if a Helm Chart has a 'deployed' status - its Helm Release document can be opened by double-click. |
Fixes: redhat-developer#3990 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
d94bf49 to
bb0bfab
Compare
datho7561
left a comment
There was a problem hiding this comment.
Looks good. The Serverless failure is legitimate, but unrelated.
Fixes: #3990