Fix login to sandbox workflow#4109
Merged
vrubezhny merged 1 commit intoredhat-developer:mainfrom May 9, 2024
Merged
Conversation
- Install portfinder as a runtime dependency (needed to start the extension when running as a vsix) - Remove the hack to create a service account to avoid being logged out. - Find and switch to the user's project when logging into a sandbox cluster - Fix the missing logo in the add cluster page Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
requested review from
msivasubramaniaan and
vrubezhny
and removed request for
msivasubramaniaan
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4109 +/- ##
===========================================
+ Coverage 32.37% 44.84% +12.46%
===========================================
Files 85 86 +1
Lines 6505 6924 +419
Branches 1349 1446 +97
===========================================
+ Hits 2106 3105 +999
+ Misses 4399 3819 -580 ☔ View full report in Codecov by Sentry. |
vrubezhny
approved these changes
May 9, 2024
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 13, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 13, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 14, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 15, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 15, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 15, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 16, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 16, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Improved the detection whether we're logged in to a cluster or not. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 16, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Improved the detection whether we're logged in to a cluster or not. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 16, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Improved the detection whether we're logged in to a cluster or not. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 17, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Improved the detection whether we're logged in to a cluster or not. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 17, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Improved the detection whether we're logged in to a cluster or not. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 17, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Improved the detection whether we're logged in to a cluster or not. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
May 17, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: redhat-developer#3999 - The project listing is fixed, so annotated projects are shown now Fixes: redhat-developer#4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to redhat-developer#4109) Issue: redhat-developer#4080 (?) Improved the detection whether we're logged in to a cluster or not. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
that referenced
this pull request
May 17, 2024
- Now, when switching projects/namespaces, one can manually type in a project name to be set as an active one. - No more 'Missing project/namespace' item for a project/namespace that doesn't exist on a cluster. This allows working normally on clusters with restrictions on list for projects. Fixes: #3999 - The project listing is fixed, so annotated projects are shown now Fixes: #4101 - For a Sandbox cluster a project which name contains current user name is used as a default one when logging in (A follow up to #4109) Issue: #4080 (?) Improved the detection whether we're logged in to a cluster or not. Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Thompson davthomp@redhat.com