Fix bugs in Helm Chart browser#4158
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom May 27, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4158 +/- ##
===========================================
+ Coverage 32.37% 44.26% +11.88%
===========================================
Files 85 90 +5
Lines 6505 7234 +729
Branches 1349 1525 +176
===========================================
+ Hits 2106 3202 +1096
+ Misses 4399 4032 -367 ☔ View full report in Codecov by Sentry. |
vrubezhny
approved these changes
May 27, 2024
Contributor
vrubezhny
left a comment
vrubezhny
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
- Fix bug where sometimes the charts don't load sometimes on Linux - Fix bug where view is stuck loading when there are no repos or charts - Clean up some of the code Fixes redhat-developer#4083 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
fix-helm-chart-browser-bugs
branch
from
02af7c4 to
39d8a07
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4083
Signed-off-by: David Thompson davthomp@redhat.com