Trim token value from Clipboard#4166
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom May 30, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4166 +/- ##
===========================================
+ Coverage 32.37% 44.09% +11.72%
===========================================
Files 85 91 +6
Lines 6505 7291 +786
Branches 1349 1523 +174
===========================================
+ Hits 2106 3215 +1109
+ Misses 4399 4076 -323 ☔ View full report in Codecov by Sentry. |
Also the sha256-token validation is fixed Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
cd563e9 to
855512f
Compare
datho7561
approved these changes
May 30, 2024
Contributor
datho7561
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks, Victor!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also the sha256-token validation is fixed.
When using 'Developer Sandbox` to login to the DevSandbox and a token is already stored in the Clipboard, its value isn't trimmed before its validation and usage:
So, when the sha256-token value begins with a whitespace character the
Login to DevSandboxbutton is shown as disabled and its tooltip says: "Token in clibboard is invalid....":Also, the sha256 token validation RegEx incorrectly validates provided token - it doesn't accept
-character as a part of token value and doesn't control the ending thus allowing a whitespaces or any text to be placed after a whitespace or '-' character.