Skip to content

Use the value saved in the clipboard when logging in using a token #4165#4179

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-use-token-from-clipboard
Jun 6, 2024
Merged

Use the value saved in the clipboard when logging in using a token #4165#4179
datho7561 merged 1 commit intoredhat-developer:mainfrom
vrubezhny:fix-use-token-from-clipboard

Conversation

@vrubezhny
Copy link
Copy Markdown
Contributor

Fixes: #4165

@vrubezhny vrubezhny force-pushed the fix-use-token-from-clipboard branch from 94f0052 to e8a4731 Compare June 6, 2024 00:25
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 24 lines in your changes missing coverage. Please review.

Project coverage is 43.68%. Comparing base (da60441) to head (d94e1ad).
Report is 270 commits behind head on main.

Files Patch % Lines
src/util/inputValue.ts 28.00% 18 Missing ⚠️
src/openshift/cluster.ts 33.33% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4179       +/-   ##
===========================================
+ Coverage   32.37%   43.68%   +11.30%     
===========================================
  Files          85       95       +10     
  Lines        6505     7710     +1205     
  Branches     1349     1647      +298     
===========================================
+ Hits         2106     3368     +1262     
+ Misses       4399     4342       -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vrubezhny
Copy link
Copy Markdown
Contributor Author

When entering a token, its value is initialized from the Clipboard if it contains a valid sha256 token.
The following buttons are added to the Input Field:

  • "Paste from Clibpoard" - allows pasting a value from the Clipboard (the value gets validated before paste, so this allows to paste the only the values that successfully pass the validation)
  • "Show value"/"Hide value" - allows to make visible/hidden a "password"-like value (is shown only if entering "password"-like values (passwords, tokens, etc))
Screencast.from.2024-06-06.01-52-33.webm

@vrubezhny vrubezhny force-pushed the fix-use-token-from-clipboard branch from e8a4731 to d94e1ad Compare June 6, 2024 04:14
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it works like a charm. Thanks, Victor!

@datho7561 datho7561 merged commit c6dce89 into redhat-developer:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the value saved in the clipboard when logging in using a token

3 participants