There is no any error/warning notification when Helm Chart cannot be installed #4172

[vrubezhny]

Fixes: #4172

[vrubezhny]

The PR enables the error reporting on Helm Chart installation failure:

Screencast.from.2024-06-14.03-21-15.webm

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.69%. Comparing base (da60441) to head (ad8bedd).
Report is 291 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4206       +/-   ##
===========================================
+ Coverage   32.37%   43.69%   +11.31%     
===========================================
  Files          85       95       +10     
  Lines        6505     7711     +1206     
  Branches     1349     1647      +298     
===========================================
+ Hits         2106     3369     +1263     
+ Misses       4399     4342       -57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[msivasubramaniaan]

LGTM

[mohitsuman]

@vrubezhny, after the Helm Chart is installed, a "VS Code notification bar indicating the installation is successful" should appear. This notification aids in determining whether the installation process succeeded or failed.

[vrubezhny]

@vrubezhny, after the Helm Chart is installed, a "VS Code notification bar indicating the installation is successful" should appear. This notification aids in determining whether the installation process succeeded or failed.

@mohitsuman As you can see on the screencasts the issue #4172 (comment) and here after the fix #4206 (comment) there is "Installing ....` information message when the installation starts, but there is no any "VSCode notification bars" appearing after the successful installation.

Do you want me to add such a notification message? (I suppose it should be an informational message then).

In case of a failure, I believe, the error message appearing on the Helm Chart installation pane is enough to notify the user, isn't it?

[datho7561]

Works well, but the code can be cleaned up a little. Feel free to fix it or merge as-is.

I think it's okay for the time being to not include a notification that the chart was installed successfully, since currently the user is notified to this fact by the popup window within the webview closing.

[vrubezhny]

I think it's okay for the time being to not include a notification that the chart was installed successfully, since currently the user is notified to this fact by the popup window within the webview closing.

So OK. I'm merging it in. Feel free to open an issue if we need any other notifications to be added