Skip to content

Change the way we show progress for long running commands#422

Merged
dgolovin merged 4 commits intoredhat-developer:masterfrom
dgolovin:issue-368
Nov 30, 2018
Merged

Change the way we show progress for long running commands#422
dgolovin merged 4 commits intoredhat-developer:masterfrom
dgolovin:issue-368

Conversation

@dgolovin
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin commented Nov 30, 2018

Improve progress reporting for #368.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 30, 2018

Codecov Report

Merging #422 into master will decrease coverage by 0.17%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   81.32%   81.14%   -0.18%     
==========================================
  Files          20       20              
  Lines         905      907       +2     
  Branches      145      145              
==========================================
  Hits          736      736              
- Misses        169      171       +2
Impacted Files Coverage Δ
src/openshift/component.ts 75% <100%> (+0.54%) ⬆️
src/openshift/service.ts 70% <25%> (-4.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c44873...b1cdee3. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 30, 2018

Codecov Report

Merging #422 into master will decrease coverage by 0.04%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   81.32%   81.27%   -0.05%     
==========================================
  Files          20       20              
  Lines         905      908       +3     
  Branches      145      145              
==========================================
+ Hits          736      738       +2     
- Misses        169      170       +1
Impacted Files Coverage Δ
src/openshift/openshiftItem.ts 62.5% <0%> (-8.93%) ⬇️
src/openshift/component.ts 75% <100%> (+0.54%) ⬆️
src/openshift/service.ts 74% <25%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4398c24...fd7fdd4. Read the comment docs.

@dgolovin dgolovin changed the title [WIP] Change the way we show progress for long running commands Change the way we show progress for long running commands Nov 30, 2018
@dgolovin dgolovin merged commit 7fb9c29 into redhat-developer:master Nov 30, 2018
@dgolovin dgolovin removed the review label Nov 30, 2018
@dgolovin dgolovin deleted the issue-368 branch May 27, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant