Remove 'make-fetch-happen' dependency#4247
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Jul 2, 2024
Merged
Conversation
vrubezhny
force-pushed
the
fix-remove-make-fetch-happen-dependency
branch
2 times, most recently
from
a38d4c5 to
1f7db43
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4247 +/- ##
===========================================
+ Coverage 32.37% 43.81% +11.44%
===========================================
Files 85 95 +10
Lines 6505 7707 +1202
Branches 1349 1647 +298
===========================================
+ Hits 2106 3377 +1271
+ Misses 4399 4330 -69 ☔ View full report in Codecov by Sentry. |
vrubezhny
force-pushed
the
fix-remove-make-fetch-happen-dependency
branch
from
1f7db43 to
1929fe9
Compare
vrubezhny
force-pushed
the
fix-remove-make-fetch-happen-dependency
branch
from
1929fe9 to
00b45b7
Compare
datho7561
requested changes
Jul 2, 2024
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Seems to work for me, but we should update the engine version if we are making this change so that versions of VS Code that don't come with Node 18 can't download this update.
vrubezhny
force-pushed
the
fix-remove-make-fetch-happen-dependency
branch
3 times, most recently
from
6f234a2 to
21b7bcf
Compare
datho7561
reviewed
Jul 2, 2024
As Fetch API is compatible with Node.js >= v18, the engine and dependencies are accordingly updated: - engines: ``` "vscode": "^1.82.3", "npm": ">=8.6.0", "node": ">=18.0.0" ``` - devDependencies: ``` "@types/node": "^18.19.39", ... "@types/vscode": "1.82.0", ``` Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
force-pushed
the
fix-remove-make-fetch-happen-dependency
branch
from
21b7bcf to
431a178
Compare
datho7561
approved these changes
Jul 2, 2024
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Victor!
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Fetch API is compatible with Node.js >= v18, the engine and dependencies are accordingly updated: