validated bad container image URL by msivasubramaniaan · Pull Request #4283 · redhat-developer/vscode-openshift-tools

msivasubramaniaan · 2024-07-15T10:19:36Z

No description provided.

codecov-commenter · 2024-07-15T10:33:07Z

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 43.88%. Comparing base (da60441) to head (e2c3bdb).
Report is 360 commits behind head on main.

Files	Patch %	Lines
src/deployment.ts	29.41%	12 Missing ⚠️
src/oc/ocWrapper.ts	50.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4283       +/-   ##
===========================================
+ Coverage   32.37%   43.88%   +11.50%     
===========================================
  Files          85       95       +10     
  Lines        6505     7716     +1211     
  Branches     1349     1634      +285     
===========================================
+ Hits         2106     3386     +1280     
+ Misses       4399     4330       -69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vrubezhny

We should change the way we validate it. See the in line comment

…mage-url-isnt-good

vrubezhny

Looks good to me.
After moving the image info validation to onDidAccept it works really well!
Also it doesn't make any excessive 'oc' binary invocations, which is also good, imho.

datho7561 · 2024-07-15T16:22:01Z

    }

+    public async hasImageInfo(url: string): Promise<boolean> {
+        const result = await CliChannel.getInstance().executeTool(


Try this with docker.io/library/mongo. For me at least, it fails, so I can't deploy mongodb

I could successfully deploy mongodb using URL docker.io/library/mongo. Some temporary/network problem?

PS: The only problem is that it has gone into CrashLoopBackOff immediately

What version of the mongo DB image do you have? I have a31b196b207d which should be the latest image, since I recently deleted all my container images to free some space. Maybe this affects it?

I'll double check on windows

Can I check it with OS Tools somehow?

Docker says the mongo:latest is a31b196b207d...

$ docker images --no-trunc REPOSITORY TAG IMAGE ID CREATED SIZE mongo latest sha256:a31b196b207d768e78f2af331869e91d13443f691080d3b93e8009a53391eeaa 2 weeks ago 796MB

However, the Pod's config says:

... "containerStatuses": [ { "containerID": "cri-o://4080a87a588b22b75135f996350ffe331dc13b6a4423d07f550450bb9d929f43", "image": "docker.io/library/mongo:latest", "imageID": "docker.io/library/mongo@sha256:1cd3951000020c1cb1757868e6cfd82667f57d80bb31fed8b585e26a8a1d960f", ...

which actually doesn't look like the same image... Does it?

I was able to reproduce the same error on Windows. I guess you can check the status of running the command that's listed here. I don't really know what's going on

The command result is an error for me, since it detects windows and linux versions of the docker image

The command result is an error for me, since it detects windows and linux versions of the docker image

I didn't get this... So, you have the same error result while deploying the same image on Windows and *nix?
And what does it give to us?

... And yes, I think if you hit the docker pull rate limit, you'll probably won't be able to deploy any image till the counter is dropped. Not 100% sure though.

Seems to be working now for me. Does it work for you, Victor?

datho7561 · 2024-07-15T16:24:37Z

It would be nice to have some sort of indication that a verification is going on; I don't know yet how this would be implemented though.

msivasubramaniaan · 2024-07-15T17:36:31Z

It would be nice to have some sort of indication that a verification is going on; I don't know yet how this would be implemented though.

@datho7561 added progress to show the info

datho7561 · 2024-07-15T18:20:31Z

The progress indicator on the image check looks great! I'd like to figure out what's going on with the mongodb image before merging.

datho7561 · 2024-07-15T18:21:09Z

I just hit my pull rate limit for docker. Maybe this is related?

vrubezhny · 2024-07-15T20:04:04Z

I just hit my pull rate limit for docker. Maybe this is related?

If I execute oc image info docker.io/library/mongo I get quite a long list of mongo images with different versions, and the command output ends with:

error: the image is a manifest list and contains multiple images - use --filter-by-os to select from:

  OS             DIGEST
  linux/amd64    sha256:19c11a8f1064fd2bb713ef1270f79a742a184cd57d9bb922efdd2a8eca514af8
  linux/arm64/v8 sha256:f9b01e368fd95a783a68471930a15c2494d525318ff65a1b408ff3e6bc83e3d4
  windows/amd64  sha256:bbb44a208559a1fad8f164e0bd97db2b9f4b699d6adfa01ba4f20b9ec60eb832
  windows/amd64  sha256:bc25ab206f79c4618ca23b8fb5f8b2710783ed6a5058f30e8f196a85f3f5c3fb

None of these images has neither a31b196b207d (mongo:latest) nor 1cd395100002 sha256 and actually might not be full.

So, I'm not actually sure if we can really check what's getting installed with oc create deployment ... --image=docker.io/library/mongo.

datho7561 · 2024-07-15T20:24:29Z

@vrubezhny @msivasubramaniaan I think this will work, however I have exceeded the rate limit and need to wait before I can try it again:

oc image info docker.io/library/mongo:latest --show-multiarch=true

changes I made:

:latest --> This means info is only collected for the newest version of the container image

--show-multiarch=true --> from the argument description, this should prevent an error code from being returned when the container supports multiple architectures

vrubezhny · 2024-07-15T21:26:05Z

oc image info docker.io/library/mongo:latest --show-multiarch=true

Do you suggest adding :latest and --show-multiarch=true to the command arguments?

If so, we should take care if user has NOT already added any tags to the URL (like :latest)

datho7561

Looks good to me! Thanks, Muthu!

vrubezhny

Looks good to me. Thanks!

validated bad container image URL

532b069

msivasubramaniaan requested review from datho7561 and vrubezhny July 15, 2024 10:19

msivasubramaniaan self-assigned this Jul 15, 2024

msivasubramaniaan linked an issue Jul 15, 2024 that may be closed by this pull request

Workflow for entering a bad container image URL isn't good #3911

Closed

vrubezhny requested changes Jul 15, 2024

View reviewed changes

Comment thread src/deployment.ts Outdated

msivasubramaniaan added this to the 1.16.0 milestone Jul 15, 2024

msivasubramaniaan added 2 commits July 15, 2024 19:12

Merge branch 'main' into 3911-workflow-for-entering-a-bad-container-i…

e1be296

…mage-url-isnt-good

moved validation under onDid method

aee0e9d

msivasubramaniaan requested a review from vrubezhny July 15, 2024 13:54

msivasubramaniaan removed this from the 1.16.0 milestone Jul 15, 2024

vrubezhny previously approved these changes Jul 15, 2024

View reviewed changes

datho7561 requested changes Jul 15, 2024

View reviewed changes

add progress while getting info

405d3da

msivasubramaniaan dismissed vrubezhny’s stale review via 405d3da July 15, 2024 17:35

msivasubramaniaan requested review from datho7561 and vrubezhny July 15, 2024 17:36

added --show-multiarch=true param and latest tag

e2c3bdb

datho7561 approved these changes Jul 16, 2024

View reviewed changes

vrubezhny approved these changes Jul 16, 2024

View reviewed changes

vrubezhny merged commit 5917478 into redhat-developer:main Jul 16, 2024

vrubezhny added this to the 1.15.0 milestone Jul 16, 2024

Conversation

msivasubramaniaan commented Jul 15, 2024

Uh oh!

codecov-commenter commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vrubezhny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vrubezhny left a comment

Choose a reason for hiding this comment

Uh oh!

datho7561 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

vrubezhny Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datho7561 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

datho7561 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

vrubezhny Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datho7561 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

datho7561 Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

vrubezhny Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

datho7561 Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

datho7561 commented Jul 15, 2024

Uh oh!

msivasubramaniaan commented Jul 15, 2024

Uh oh!

datho7561 commented Jul 15, 2024

Uh oh!

datho7561 commented Jul 15, 2024

Uh oh!

vrubezhny commented Jul 15, 2024

Uh oh!

datho7561 commented Jul 15, 2024

Uh oh!

vrubezhny commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datho7561 left a comment

Choose a reason for hiding this comment

Uh oh!

vrubezhny left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Jul 15, 2024 •

edited

Loading

vrubezhny Jul 15, 2024 •

edited

Loading

vrubezhny Jul 15, 2024 •

edited

Loading

vrubezhny Jul 15, 2024 •

edited

Loading

vrubezhny commented Jul 15, 2024 •

edited

Loading