removed syntax high light and added code mirror for showing YAML#4428
Merged
datho7561 merged 2 commits intoredhat-developer:mainfrom Sep 4, 2024
Conversation
Collaborator
msivasubramaniaan
commented
Sep 4, 2024
msivasubramaniaan
commented
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4428 +/- ##
===========================================
+ Coverage 32.37% 43.58% +11.21%
===========================================
Files 85 98 +13
Lines 6505 7991 +1486
Branches 1349 1703 +354
===========================================
+ Hits 2106 3483 +1377
- Misses 4399 4508 +109 ☔ View full report in Codecov by Sentry. |
datho7561
requested changes
Sep 4, 2024
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
One small change, but otherwise looks good
| ); | ||
| } | ||
|
|
||
| /*const vscodeTheme = createTheme({ |
Contributor
There was a problem hiding this comment.
If you aren't using this code, please remove it
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Collaborator
Author
Sorry thought of remove it, somehow missed |
datho7561
approved these changes
Sep 4, 2024
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Muthu!
msivasubramaniaan
deleted the
4426-get-rid-of-react-syntax-highlighter-dependency
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.