Use SSO account to configure sandbox in one click#4439
Merged
vrubezhny merged 1 commit intoredhat-developer:mainfrom Sep 12, 2024
Merged
Use SSO account to configure sandbox in one click#4439vrubezhny merged 1 commit intoredhat-developer:mainfrom
vrubezhny merged 1 commit intoredhat-developer:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4439 +/- ##
===========================================
+ Coverage 32.37% 43.39% +11.02%
===========================================
Files 85 98 +13
Lines 6505 8049 +1544
Branches 1349 1698 +349
===========================================
+ Hits 2106 3493 +1387
- Misses 4399 4556 +157 ☔ View full report in Codecov by Sentry. |
vrubezhny
force-pushed
the
fix-add-login-using-pipeline-token
branch
4 times, most recently
from
f584034 to
3b7fe95
Compare
Contributor
|
I gave it a try and couldn't get it working; I'll try again tomorrow morning |
Uses a POC ['feat: use sso account to configure sandbox in one click redhat-developer#4232'](redhat-developer#4232) by @dgolovin. Allows logging in to the DevSandbox using a SSO account if Service Account pipeline token is configured, otherwise a token from the Clipboard is to be used. Co-authored-by: Denis Golovin <dgolovin@redhat.com> Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
force-pushed
the
fix-add-login-using-pipeline-token
branch
from
3b7fe95 to
ed9e623
Compare
Contributor
Author
@datho7561, Hm... Still works for me with no any problem. Rebased, please update before give it a try again. |
datho7561
approved these changes
Sep 12, 2024
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Works very well for me! Thanks, Victor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a POC 'feat: use sso account to configure sandbox in one click #4232' by @dgolovin.
Allows logging in to the DevSandbox using a SSO account by creating a token and installing it into the pipeline Service Account, otherwise, if a token cannot be created/installed, a token from the Clipboard is to be used.
Screencast.from.2024-09-09.03-31-15.mp4