Devfile Registry editor is to allow devfile version selection and use…

[vrubezhny]

… when creating a component #4189

Fixes: #4189
Issue: #3850

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 51.93798% with 124 lines in your changes missing coverage. Please review.

Project coverage is 43.51%. Comparing base (da60441) to head (670fabd).
Report is 572 commits behind head on main.

Files with missing lines	Patch %	Lines
src/webview/devfile-registry/registryViewLoader.ts	21.73%	36 Missing ⚠️
.../webview/create-component/createComponentLoader.ts	38.18%	34 Missing ⚠️
src/registriesView.ts	23.25%	33 Missing ⚠️
src/webview/common-ext/createComponentHelpers.ts	54.16%	11 Missing ⚠️
src/devfile-registry/devfileRegistryWrapper.ts	87.65%	10 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4467       +/-   ##
===========================================
+ Coverage   32.37%   43.51%   +11.13%     
===========================================
  Files          85       98       +13     
  Lines        6505     8002     +1497     
  Branches     1349     1702      +353     
===========================================
+ Hits         2106     3482     +1376     
- Misses       4399     4520      +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datho7561]

adding new Devfile registries doesn't seem to work. I tried to add http://registry.stage.devfile.io , and nothing happened: no warnings and it didn't appear in the "Devfile Registries" section of the sidebar

[vrubezhny]

adding new Devfile registries doesn't seem to work. I tried to add http://registry.stage.devfile.io , and nothing happened: no warnings and it didn't appear in the "Devfile Registries" section of the sidebar

Try refreshing the Devfile Registry View tree - that is a known issue I fixed in #4473.

[datho7561]

Refreshing didn't work for me. That other PR says that it depends on this one in order to work - is that still the case? Is it possible to move the fix to this PR?

[vrubezhny]

Refreshing didn't work for me. That other PR says that it depends on this one in order to work - is that still the case? Is it possible to move the fix to this PR?

I could try implementing the fix in this PR... the problem is that it'll need to make even more changes in depending #4473 due to conflicts (as it changes the same code)

[datho7561]

Should I focus on reviewing the other PR then?

[vrubezhny]

Should I focus on reviewing the other PR then?

Adding/removing devfile registries are not the part of this PR....

With this one you can focus on the following goals:

1. to provide a possibility to change the version of a devfile when creating a component (from Devfile Registry editor, a template, a git repository or a local codebase) and making sure that everything still works and the selected devfile version is really applied for a component created.
2. Overall performance improvement (we don't need to read whole the devfile registries contents together with the default devfile versions attached into the memory at start and keep it in while working with the extension).
3. getting rid of odo registry and odo registry --detail usages

The #4473 - is exactly about devfile registry tree, adding/changing/removing registries, refreshing the tree and the cache maintenance and getting rid of odo preference view, odo preference add registry and odo preference remove registry

[datho7561]

Looks good! Thanks, Victor! Thanks for your patience during the review.