Fix Devfile Registry editor views for cases where the current Devfile…

[vrubezhny]

… Registry is removed

This will show an error instead of Devfile search form, a Devfile selection dialog, etc. and will ask if user wants to close the view when the current Devfile Registry is removed.

The following cases where fixed:

• Switching between displaying a specified Devfile Registry contents to displaying the contents of all the available registries:

Screencast.from.2024-10-09.00-26-10.mp4

• Closing a Devfile Registry view when a devfile registry is removed while a devfile from that registry is selected:

Screencast.from.2024-10-09.00-23-27.mp4

• Closing a Devfile Registry view when a devfile registry is removed while a devfile from that registry is selected and promoted to 'Select Name and Folder' page:

Screencast.from.2024-10-09.00-25-20.mp4

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 43.82%. Comparing base (da60441) to head (153ed19).
Report is 622 commits behind head on main.

Files with missing lines	Patch %	Lines
src/webview/devfile-registry/registryViewLoader.ts	33.33%	8 Missing ⚠️
.../webview/create-component/createComponentLoader.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #4536       +/-   ##
===========================================
+ Coverage   32.37%   43.82%   +11.44%     
===========================================
  Files          85       99       +14     
  Lines        6505     8067     +1562     
  Branches     1349     1692      +343     
===========================================
+ Hits         2106     3535     +1429     
- Misses       4399     4532      +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[datho7561]

Works like a charm! Thanks, Victor!

[adietish]

@datho7561, @vrubezhny: does this fix #3289?

[vrubezhny]

@datho7561, @vrubezhny: does this fix #3289?

Nope. This PR is not about top spacing in Devfile Registries view nor view scaling related...
However, I see that now we've lost Devfile Registry header for some reason... need to check why and when it happened.

[adietish]

@datho7561, @vrubezhny: does this fix #3289?

Nope. This PR is not about top spacing in Devfile Registries view nor view scaling related... However, I see that now we've lost Devfile Registry header for some reason... need to check why and when it happened.

@vrubezhny ok, guess file a new issue? I created #4587