Fix port validation in Create Component from Local Codebase#4552
Merged
vrubezhny merged 1 commit intoredhat-developer:mainfrom Oct 13, 2024
Merged
Conversation
Contributor
vrubezhny
commented
Oct 13, 2024
vrubezhny
commented
``` rejected promise not handled within 1 second: TypeError: Cannot read properties of undefined (reading 'toString') extensionHostProcess.js:162 stack trace: TypeError: Cannot read properties of undefined (reading 'toString') at validatePortNumber (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/common-ext/createComponentHelpers.js:170:29) at gh.<anonymous> (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:193:95) at Generator.next (<anonymous>) at /home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:8:71 at new Promise (<anonymous>) at __awaiter (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:4:12) at gh.messageHandler [as value] (/home/jeremy/projects/vscode-openshift-tools/source/vscode-openshift-tools/out/src/webview/create-component/createComponentLoader.js:91:16) ``` Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4552 +/- ##
===========================================
+ Coverage 32.37% 43.83% +11.45%
===========================================
Files 85 99 +14
Lines 6505 8067 +1562
Branches 1349 1710 +361
===========================================
+ Hits 2106 3536 +1430
- Misses 4399 4531 +132 ☔ View full report in Codecov by Sentry. |
Contributor
|
@vrubezhny can you please tell me if there was an issue that I can link? |
Contributor
Author
@adietish There is no existing issue for this error. Please link the PR itself |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.