Remove "Bind Service" feature due to the deprecation of the Service Binding Operator #4682#4681
Merged
vrubezhny merged 1 commit intoredhat-developer:mainfrom Dec 4, 2024
Conversation
vrubezhny
force-pushed
the
fix-configure-cluster-cnpg-in-continuous-integration-workflow
branch
4 times, most recently
from
0c77b7d to
8b160f1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4681 +/- ##
===========================================
+ Coverage 32.37% 44.66% +12.28%
===========================================
Files 85 99 +14
Lines 6505 8110 +1605
Branches 1349 1722 +373
===========================================
+ Hits 2106 3622 +1516
- Misses 4399 4488 +89 ☔ View full report in Codecov by Sentry. |
vrubezhny
force-pushed
the
fix-configure-cluster-cnpg-in-continuous-integration-workflow
branch
3 times, most recently
from
be2c0f5 to
6f3dae7
Compare
vrubezhny
changed the title
datho7561
requested changes
Dec 3, 2024
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
It seems to me that the "Create Service Binding" feature has been removed properly. I left a few comments about some error popups that you are outputting.
vrubezhny
force-pushed
the
fix-configure-cluster-cnpg-in-continuous-integration-workflow
branch
from
6f3dae7 to
b743b7e
Compare
…inding Operator redhat-developer#4682 Issue: redhat-developer#4682 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
force-pushed
the
fix-configure-cluster-cnpg-in-continuous-integration-workflow
branch
from
b743b7e to
0c76878
Compare
datho7561
approved these changes
Dec 4, 2024
Contributor
Author
|
@datho7561 Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #4682