Allow people to use KUBECONFIG env var and multiple config files #4816#5005
Conversation
1044859 to
7cd4d60
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5005 +/- ##
===========================================
+ Coverage 32.37% 44.79% +12.41%
===========================================
Files 85 99 +14
Lines 6505 8399 +1894
Branches 1349 1786 +437
===========================================
+ Hits 2106 3762 +1656
- Misses 4399 4637 +238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b86503c to
0e20f3f
Compare
datho7561
left a comment
There was a problem hiding this comment.
Works well for me when I have kind and minikube set up in different config files. Not sure when the greyed out icon is used, but other than that the code looks reasonable. Thanks, Victor!
There was a problem hiding this comment.
When displaying a list of available clusters in Login QuickPick the current active cluster we're logged in is shown with a "red" colored icon, while the others are ahown with a "grey" icon:
Note: we actually might be logged in to more than one cluster at the same time, the "red"-icon will be used only for the cluster, that is referenced in the "current-context", so other clusters we might be logged in too will still be shown with a "grey" icon.
The "current" cluster is always displayed at the top of the list.
0e20f3f to
200d303
Compare
…at-developer#4816 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
200d303 to
cad5d26
Compare

Fixes #4816