Provide keybinding for Login, push and refresh commands#835
Provide keybinding for Login, push and refresh commands#835dgolovin merged 4 commits intoredhat-developer:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #835 +/- ##
==========================================
- Coverage 93.43% 93.27% -0.16%
==========================================
Files 23 23
Lines 1416 1428 +12
Branches 234 235 +1
==========================================
+ Hits 1323 1332 +9
- Misses 93 96 +3
Continue to review full report at Codecov.
|
| if (!component) return null; | ||
| Component.odo.executeInTerminal(Command.pushComponent(component.getParent().getParent().getName(), component.getParent().getName(), component.getName())); | ||
| const getPushCmd = await Component.getPushCmd(); | ||
| if (getPushCmd && !context) { |
There was a problem hiding this comment.
With this check in place there is no way to use push command from command palette. After first push it will always push the same component until context menu for component in tree is used.
You need to create new command 'OpenShift: Repeat last push command'.
| "In which Application you want to push the changes", | ||
| "For which Component you want to push the changes"); | ||
| if (!component) return null; | ||
| Component.setPushCmd(component.getName(), component.getParent().getName(), component.getParent().getParent().getName()); |
There was a problem hiding this comment.
You should be just saving
() => {
Component.odo.executeInTerminal(Command.pushComponent(component.getParent().getParent().getName(), component.getParent().getName(), component.getName()));
}here.
@sudhirverma please use: Fix #820 description instead, so merging the PR would automatically close the issue. |
2 participants
Fix: #820