Skip to content

Provide cluster and usernames from k8 config for login#903

Merged
dgolovin merged 10 commits intoredhat-developer:masterfrom
mohitsuman:gh-26
Jun 26, 2019
Merged

Provide cluster and usernames from k8 config for login#903
dgolovin merged 10 commits intoredhat-developer:masterfrom
mohitsuman:gh-26

Conversation

@mohitsuman
Copy link
Copy Markdown
Contributor

@mohitsuman mohitsuman commented Jun 22, 2019

Fix #671

Cluster View
Screenshot 2019-06-22 at 10 24 36 AM

UserName
Screenshot 2019-06-22 at 10 24 46 AM

The new UI also mentions the current context of from k8 config.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2019

Codecov Report

Merging #903 into master will increase coverage by 0.01%.
The diff coverage is 93.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #903      +/-   ##
==========================================
+ Coverage   91.73%   91.74%   +0.01%     
==========================================
  Files          24       25       +1     
  Lines        1464     1503      +39     
  Branches      238      247       +9     
==========================================
+ Hits         1343     1379      +36     
- Misses        121      124       +3
Impacted Files Coverage Δ
src/k8s/deployment.ts 12% <ø> (ø) ⬆️
src/openshift/component.ts 98.42% <100%> (ø) ⬆️
src/cli.ts 94.73% <100%> (ø) ⬆️
src/openshift/cluster.ts 98.38% <92%> (-1.62%) ⬇️
src/util/kubeUtils.ts 94.73% <94.73%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88c1a6...26c6638. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2019

Codecov Report

Merging #903 into master will decrease coverage by 10%.
The diff coverage is 16.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #903       +/-   ##
===========================================
- Coverage   91.73%   81.73%   -10.01%     
===========================================
  Files          24       25        +1     
  Lines        1464     1511       +47     
  Branches      238      250       +12     
===========================================
- Hits         1343     1235      -108     
- Misses        121      276      +155
Impacted Files Coverage Δ
src/k8s/deployment.ts 12% <ø> (ø) ⬆️
src/openshift/component.ts 98.42% <100%> (ø) ⬆️
src/cli.ts 94.73% <100%> (ø) ⬆️
src/util/kubeUtils.ts 17.24% <17.24%> (ø)
src/openshift/cluster.ts 8.19% <8%> (-91.81%) ⬇️
src/openshift/openshiftItem.ts 83.33% <0%> (-16.67%) ⬇️
src/odo.ts 90.04% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88c1a6...cf14b7b. Read the comment docs.

@mohitsuman
Copy link
Copy Markdown
Contributor Author

testPR

@mohitsuman mohitsuman requested a review from dgolovin June 25, 2019 10:01
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should handle corner cases, like empty ~/.kube/config or no config at all.

Comment thread src/util/kubeUtils.ts Outdated
Comment thread src/util/kubeUtils.ts Outdated
Comment thread src/util/kubeUtils.ts Outdated
Copy link
Copy Markdown
Collaborator

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not mix dependency update with new features and fixes.

@dgolovin dgolovin merged commit 8d21075 into redhat-developer:master Jun 26, 2019
@mohitsuman mohitsuman deleted the gh-26 branch June 16, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide cluster and usernames from k8 config for login

3 participants