Skip to content

Explicitly use codecov token#910

Closed
jrichter1 wants to merge 2 commits intoredhat-developer:azure-cifrom
jrichter1:codecov-token
Closed

Explicitly use codecov token#910
jrichter1 wants to merge 2 commits intoredhat-developer:azure-cifrom
jrichter1:codecov-token

Conversation

@jrichter1
Copy link
Copy Markdown
Member

trying out loading the codecov token directly from the scripts

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2019

Codecov Report

Merging #910 into azure-ci will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           azure-ci     #910   +/-   ##
=========================================
  Coverage     91.73%   91.73%           
=========================================
  Files            24       24           
  Lines          1464     1464           
  Branches        238      238           
=========================================
  Hits           1343     1343           
  Misses          121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6861979...4d15fee. Read the comment docs.

@mohitsuman
Copy link
Copy Markdown
Contributor

mohitsuman commented Jun 27, 2019

It still fails, as Provided token is not a UUID. I tried to look other docs how they have integrated it. They use the token variable directly in the pipeline script itself.

      - script: |
          npm run coverage:upload -t $(CODECOV_TOKEN)
        displayName: 'Upload coverage to codecov.io'

@jrichter1 jrichter1 force-pushed the codecov-token branch 3 times, most recently from fe3fa7c to 1c17603 Compare June 27, 2019 11:16
@jrichter1
Copy link
Copy Markdown
Member Author

jrichter1 commented Jun 27, 2019

Apparently, this version works. It's linux specific, though.

@mohitsuman
Copy link
Copy Markdown
Contributor

It still gets FetchError though. But we need to fix it somehow for the other OS variants.

@mohitsuman
Copy link
Copy Markdown
Contributor

/AzurePipelines run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mohitsuman
Copy link
Copy Markdown
Contributor

Closinng this as the fix is done by #911

@mohitsuman mohitsuman closed this Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants