Skip to content

Improve application.properties TextMate grammar #233

@xorye

Description

@xorye

There are pros and cons between the old textmate grammar and the new textmate grammar introduced in #230

Here are some cases where the two grammars act differently.

Multiline property keys (old grammar is preferable):

Old grammar:
image

New grammar:
image

Multiline property values (new grammar is preferable):

Old grammar:
image

New grammar:
image

Apostrophes (old grammar is preferable):

Old grammar:
image

New grammar:
image

For the new grammar, the issue about the apostrophes is here: textmate/ini.tmbundle#3 and the PR that fixes seems to fix that issue is here: textmate/ini.tmbundle#1

I've thought of three approaches we can take (please, by all means, suggest more approaches if there are better ones). The approaches are in no particular order.

To satisfy the cases above, we can either :

  • Go back to the old grammar and build on top of it

OR

  • Create issues in VS Code's repository to fix the grammars

OR

  • Build on top of the VS Code's grammar ourselves since 2. might take a long time

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions