Ask user to specify build tool for project generation#137
Merged
fbricon merged 1 commit intoredhat-developer:masterfrom Nov 7, 2019
xorye:108create_gradle
Merged
Ask user to specify build tool for project generation#137fbricon merged 1 commit intoredhat-developer:masterfrom xorye:108create_gradle
fbricon merged 1 commit intoredhat-developer:masterfrom
xorye:108create_gradle
Conversation
xorye
commented
Nov 6, 2019
fbricon
reviewed
Nov 6, 2019
| } | ||
|
|
||
| const quickPickItems = [{label: 'Maven', value: 'MAVEN'}, {label: 'Gradle', value: 'GRADLE'}]; | ||
|
|
Collaborator
There was a problem hiding this comment.
build tool choice should be remembered
Contributor
Author
There was a problem hiding this comment.
After the first time the user selects a build tool, it saves the choice so next time, the build tool selection step is skipped? And then to change the build tool, maybe add a vscode setting?
Collaborator
There was a problem hiding this comment.
no, just preselect it, keep it displayed
Signed-off-by: David Kwon <dakwon@redhat.com>
Contributor
Author
|
@fbricon I've made the changes. Depending on what the user selected before, the order of the options are different:
|
Contributor
Author
|
Defaults to Maven |
Contributor
Author
|
I recently learned that you can set the activeItem for a quick pick. I will do that instead of changing the order of the items. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
Adds the ability to create a Gradle project:
Signed-off-by: David Kwon dakwon@redhat.com