Add a command to build a binary of a Quarkus app#341
Merged
datho7561 merged 1 commit intoredhat-developer:masterfrom Jul 9, 2021
Merged
Add a command to build a binary of a Quarkus app#341datho7561 merged 1 commit intoredhat-developer:masterfrom
datho7561 merged 1 commit intoredhat-developer:masterfrom
Conversation
datho7561
commented
Mar 18, 2021
Contributor
Author
|
New Demo: https://youtu.be/qleIxqrqbLs |
datho7561
force-pushed
the
335-more-tasks
branch
from
6d5d526 to
f21bce5
Compare
Contributor
Author
|
I rebased this PR and added a section about collecting telemetry when the command is run. |
rgrunber
reviewed
Jul 8, 2021
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Seems to be working pretty well. Just ran into a small issue, and maybe we could have better support for other environment variables.
datho7561
force-pushed
the
335-more-tasks
branch
2 times, most recently
from
9ecc486 to
78a2edf
Compare
rgrunber
approved these changes
Jul 9, 2021
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
I think just updating the README with the new command.
* Adds a command that generates, then executes
a `tasks.json` task that builds a binary
* After you have used the command once, you can
build a binary either through the command or
`<Ctrl>+<Shift>+B` > Quarkus: Generate a binary
* The command checks to make sure GRAALVM_HOME is set before
building the binary, and provides a link to the Quarkus docs if
it's not set up.
This PR addresses one aspect of redhat-developer#335
Signed-off-by: David Thompson <davthomp@redhat.com>
rgrunber
approved these changes
Jul 9, 2021
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Change looks good. I think it should be fine to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tasks.jsontask that builds a binary<Ctrl>+<Shift>+B> Quarkus: Generate a binaryThis PR addresses one aspect of #335
Signed-off-by: David Thompson davthomp@redhat.com