Mention required NodeJS 14.x in CONTRIBUTING.md#357
Merged
datho7561 merged 2 commits intoredhat-developer:masterfrom Aug 9, 2021
Merged
Conversation
datho7561
reviewed
May 10, 2021
Contributor
|
It seems that I have similar problem with
|
When using NodeJS version higher than 14 `npm install` fails to install @nut-tree/opencv-build-linux package Signed-off-by: Denis Golovin dgolovin@redhat.com
Signed-off-by: Denis Golovin dgolovin@redhat.com
9399f03 to
7fce922
Compare
Contributor
Author
|
@angelozerr I suggest to remove package-lock.json before running 'npm install'. Node.js 10.16.0 works for me. |
Contributor
|
@dgolovin my problem was about npm version (not about node version). Indeed I install as global the |
datho7561
approved these changes
Aug 9, 2021
Contributor
datho7561
left a comment
There was a problem hiding this comment.
I think this change looks good in terms of listing the NodeJS requirement. I think we can merge this. We can add another change to list the NPM requirement (6.y.z)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using NodeJS version higher than 14
npm installfails to install @nut-tree/opencv-build-linux packageSigned-off-by: Denis Golovin dgolovin@redhat.com