Increase test timeouts and fix OpenAPI download#384
Merged
datho7561 merged 1 commit intoredhat-developer:masterfrom Aug 12, 2021
Merged
Increase test timeouts and fix OpenAPI download#384datho7561 merged 1 commit intoredhat-developer:masterfrom
datho7561 merged 1 commit intoredhat-developer:masterfrom
Conversation
datho7561
force-pushed
the
379-tests-timeout
branch
8 times, most recently
from
e1b4a5c to
d6e0980
Compare
Closes redhat-developer#379 Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
379-tests-timeout
branch
from
d6e0980 to
2abca39
Compare
datho7561
changed the title
rgrunber
approved these changes
Aug 12, 2021
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
LGTM. I'm not able to reproduce the failure locally with test-ui but the change makes sense.
Contributor
Author
|
Thanks for the review, Roland! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to handle downloading the OpenAPI YAML file had a bug which caused it to intermittently fail. As the size of the YAML document got larger, the failures became more consistent, so I was able to pinpoint the issue.
Closes #379
Signed-off-by: David Thompson davthomp@redhat.com