Support for textDocument/InlayHint#474
Conversation
angelozerr
force-pushed
the
inlayhint
branch
2 times, most recently
from
1b7d48c to
6231a1d
Compare
angelozerr
force-pushed
the
inlayhint
branch
4 times, most recently
from
4e2aa57 to
662f6d0
Compare
| "bugs": "https://github.com/redhat-developer/vscode-quarkus/issues", | ||
| "engines": { | ||
| "vscode": "^1.37.0" | ||
| "vscode": "^1.65.0" |
There was a problem hiding this comment.
most likely will be incompatible with theia
There was a problem hiding this comment.
@benoitf what's the max vscode engine version compatible with theia?
There was a problem hiding this comment.
most likely will be incompatible with theia
please note vscode-java have a PR to support Inlay Hint too, and they did that too https://github.com/redhat-developer/vscode-java/pull/2354/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R26
There was a problem hiding this comment.
Yeah, it's not supported currently. https://eclipse-theia.github.io/vscode-theia-comparator/status.html .
Also, from redhat-developer/vscode-java#2183 (review), looks like updating the engine itself should not be harmful to Theia. Just have to ensure you don't call API that doesn't exist.
Update : According to https://github.com/eclipse-theia/theia/blob/master/dev-packages/application-package/src/api.ts#L21, should be 1.53.2
There was a problem hiding this comment.
Also see https://github.com/redhat-developer/vscode-java/pull/1975/files for how to adopt new API while still being compatible with older engines.
angelozerr
force-pushed
the
inlayhint
branch
2 times, most recently
from
efa489c to
4e91fa9
Compare
angelozerr
force-pushed
the
inlayhint
branch
3 times, most recently
from
4313ac8 to
51746b6
Compare
See redhat-developer/quarkus-ls#595 Signed-off-by: azerr <azerr@redhat.com>
AlexXuChen
left a comment
AlexXuChen
left a comment
There was a problem hiding this comment.
LGTM, setting works as intended
|
Thanks @AlexXuChen for the review! |
4 participants
Support for
textDocument/InlayHintSee redhat-developer/quarkus-ls#595
Signed-off-by: azerr azerr@redhat.com