Clickable InlayHint for Java type#533
Merged
datho7561 merged 1 commit intoredhat-developer:masterfrom Aug 17, 2022
Merged
Conversation
angelozerr
force-pushed
the
clickable-inlayhint
branch
from
a0881a8 to
8b7a048
Compare
Contributor
|
Is this PR ready? If so, could you please mark it as ready for review? |
Contributor
Author
|
Yes it is ready. I switched to real pr |
datho7561
requested changes
Aug 17, 2022
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
There are a few comments that need to be fixed, but otherwise it appears to be good
angelozerr
force-pushed
the
clickable-inlayhint
branch
from
8b7a048 to
76b9e97
Compare
Fixes redhat-developer#702 Signed-off-by: azerr <azerr@redhat.com>
datho7561
approved these changes
Aug 17, 2022
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks, Angelo!
Contributor
|
Requires redhat-developer/quarkus-ls#704 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clickable InlayHint for Java type
Fixes #702
Signed-off-by: azerr azerr@redhat.com